Always use chromium_code variable with target_conditions.

Always use chromium_code variable with target_conditions.

The chromium_code variable is designed to be set by targets.
However, if it is used in a conditions predicate in common.gypi,
it will always be false, since conditions are evaluated early.
target_conditions are evaluated late, after the target has had a
chance to set its own variables.

R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232397

[bungeman-chromium, 2013-10-31 20:56:32]

I discovered this when noticing that none of the targets in
cloud_print/service/service.gyp were getting the msvs settings which were
supposed to be guarded by the chromium_code variable. These targets were not
getting these msvs settings because the chromium_code variable is being set to 1
inside a target_defaults instead of inside a top-level variables (as it appears
is normally done). As a result, all of the conditions in common.gypi are
evaluated in a context where chromium_code is still 0.

It looks like you were the last one to do cleanup around this, so I hope you're
the right person to take a look.

[bungeman-chromium, 2013-10-31 21:30:01]

Mark, it looks like you're the one who added the target scope for the
chromium_code variable. You might want to take a look at this.

[tony, 2013-10-31 21:31:20]

On 2013/10/31 21:30:01, bungeman2 wrote:
> Mark, it looks like you're the one who added the target scope for the
> chromium_code variable. You might want to take a look at this.

I think this is correct, but Mark or Nico could confirm.

Nice find!

[Mark Mentovai, 2013-10-31 21:46:47]

LGTM. chromium_code should only be evaluated in a target_conditions context, not
in an “early” conditions context.

[bungeman-skia, 2013-11-01 15:16:31]

Committed patchset #3 manually as r232397 (presubmit successful).