Index: build/common.gypi |
=================================================================== |
--- build/common.gypi (revision 232310) |
+++ build/common.gypi (working copy) |
@@ -2731,13 +2731,17 @@ |
['win_use_allocator_shim==0', { |
'defines': ['NO_TCMALLOC'], |
}], |
- ['os_posix==1 and chromium_code==1', { |
- # Non-chromium code is not guaranteed to compile cleanly |
- # with _FORTIFY_SOURCE. Also, fortified build may fail |
- # when optimizations are disabled, so only do that for Release |
- # build. |
- 'defines': [ |
- '_FORTIFY_SOURCE=2', |
+ ['os_posix==1', { |
+ 'target_conditions': [ |
+ ['chromium_code==1', { |
+ # Non-chromium code is not guaranteed to compile cleanly |
+ # with _FORTIFY_SOURCE. Also, fortified build may fail |
+ # when optimizations are disabled, so only do that for Release |
+ # build. |
+ 'defines': [ |
+ '_FORTIFY_SOURCE=2', |
+ ], |
+ }], |
], |
}], |
['OS=="linux" or OS=="android"', { |
@@ -3708,20 +3712,24 @@ |
'-Wno-sign-promo', |
], |
}], |
- ['android_webview_build==1 and chromium_code==0', { |
- 'cflags': [ |
- # There is a class of warning which: |
- # 1) Android always enables and also treats as errors |
- # 2) Chromium ignores in third party code |
- # So we re-enable those warnings when building Android. |
- '-Wno-address', |
- '-Wno-format-security', |
- '-Wno-return-type', |
- '-Wno-sequence-point', |
+ ['android_webview_build==1', { |
+ 'target_conditions': [ |
+ ['chromium_code==0', { |
+ 'cflags': [ |
+ # There is a class of warning which: |
+ # 1) Android always enables and also treats as errors |
+ # 2) Chromium ignores in third party code |
+ # So we re-enable those warnings when building Android. |
+ '-Wno-address', |
+ '-Wno-format-security', |
+ '-Wno-return-type', |
+ '-Wno-sequence-point', |
+ ], |
+ 'cflags_cc': [ |
+ '-Wno-non-virtual-dtor', |
+ ], |
+ }], |
], |
- 'cflags_cc': [ |
- '-Wno-non-virtual-dtor', |
- ] |
}], |
['target_arch == "arm"', { |
'ldflags': [ |
@@ -4377,20 +4385,23 @@ |
'<(windows_driver_kit_path)/inc/atl71', |
'<(windows_driver_kit_path)/inc/mfc42', |
], |
- }], |
- # Workaround for intsafe in 2010 Express + WDK. ATL code uses |
- # intsafe.h and both intsafe.h and stdint.h define INT8_MIN et al. |
- # We can't use this workaround in third_party code because it has |
- # various levels of intolerance for including stdint.h. |
- ['msvs_express and chromium_code', { |
- 'msvs_system_include_dirs': [ |
- '<(DEPTH)/build', |
+ 'target_conditions': [ |
+ ['chromium_code', { |
+ # Workaround for intsafe in 2010 Express + WDK. |
+ # ATL code uses intsafe.h and both intsafe.h and stdint.h |
+ # define INT8_MIN et al. |
+ # We can't use this workaround in third_party code because |
+ # it has various levels of intolerance for including stdint.h. |
+ 'msvs_system_include_dirs': [ |
+ '<(DEPTH)/build', |
+ ], |
+ 'msvs_settings': { |
+ 'VCCLCompilerTool': { |
+ 'ForcedIncludeFiles': [ 'intsafe_workaround.h', ], |
+ }, |
+ }, |
+ }], |
], |
- 'msvs_settings': { |
- 'VCCLCompilerTool': { |
- 'ForcedIncludeFiles': [ 'intsafe_workaround.h', ], |
- }, |
- }, |
}], |
], |
'msvs_system_include_dirs': [ |