Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552803002: Get CallInterfaceDescriptor directly from CodeStub. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get CallInterfaceDescriptor directly from CodeStub. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23778

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -455 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +27 lines, -40 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +27 lines, -40 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.h View 45 chunks +61 lines, -55 lines 1 comment Download
M src/code-stubs.cc View 4 chunks +79 lines, -155 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/arm/linkage-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 10 chunks +20 lines, -28 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/linkage-impl.h View 3 chunks +14 lines, -15 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +27 lines, -40 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interface-descriptors.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +27 lines, -40 lines 1 comment Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-09-08 13:50:26 UTC) #1
mvstanton
lgtm, good stuff! https://codereview.chromium.org/552803002/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/552803002/diff/1/src/code-stubs.h#newcode183 src/code-stubs.h:183: virtual CallInterfaceDescriptor GetCallInterfaceDescriptor() { Good, I'll ...
6 years, 3 months ago (2014-09-08 14:58:39 UTC) #2
Yang
6 years, 3 months ago (2014-09-08 15:19:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 23778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698