Source/modules/geolocation/NavigatorGeolocation.h - Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/NavigatorGeolocation.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detach ApplicationCacheHost during (Oilpan) finalization Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/appcache/ApplicationCache.cpp ('K') | « Source/modules/gamepad/NavigatorGamepad.cpp ('k') | Source/modules/geolocation/NavigatorGeolocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/NavigatorGeolocation.h

diff --git a/Source/modules/geolocation/NavigatorGeolocation.h b/Source/modules/geolocation/NavigatorGeolocation.h

index b8ec63d665d83f7d9c7c79689d39cec0456bd9af..7c3f807c0f7f4dd5c368100ae6d1cc856e7e2a01 100644

--- a/Source/modules/geolocation/NavigatorGeolocation.h

+++ b/Source/modules/geolocation/NavigatorGeolocation.h

@@ -30,10 +30,10 @@ class LocalFrame;

class Geolocation;

class Navigator;

-class NavigatorGeolocation FINAL : public NoBaseWillBeGarbageCollectedFinalized<NavigatorGeolocation>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {

+class NavigatorGeolocation FINAL : public NoBaseWillBeGarbageCollected<NavigatorGeolocation>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorGeolocation);

+ DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(NavigatorGeolocation);

public:

- virtual ~NavigatorGeolocation();

static NavigatorGeolocation& from(Navigator&);

static Geolocation* geolocation(Navigator&);