Source/modules/gamepad/NavigatorGamepad.cpp - Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/gamepad/NavigatorGamepad.cpp

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detach ApplicationCacheHost during (Oilpan) finalization Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/gamepad/NavigatorGamepad.cpp

diff --git a/Source/modules/gamepad/NavigatorGamepad.cpp b/Source/modules/gamepad/NavigatorGamepad.cpp

index a6627256e2ed276552551bd68c2ecfe8c020ccf2..37b2d01e449cbc6c1a7b819278fd3dc9579b6684 100644

--- a/Source/modules/gamepad/NavigatorGamepad.cpp

+++ b/Source/modules/gamepad/NavigatorGamepad.cpp

@@ -128,6 +128,7 @@ void NavigatorGamepad::trace(Visitor* visitor)

visitor->trace(m_webkitGamepads);

visitor->trace(m_pendingEvents);

WillBeHeapSupplement<Navigator>::trace(visitor);

+ DOMWindowProperty::trace(visitor);

}

void NavigatorGamepad::didUpdateData()

@@ -180,6 +181,9 @@ NavigatorGamepad::NavigatorGamepad(LocalFrame* frame)

NavigatorGamepad::~NavigatorGamepad()

{

+#if ENABLE(OILPAN)

+ stopUpdating();

+#endif

}

const char* NavigatorGamepad::supplementName()