Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: Source/modules/webmidi/NavigatorWebMIDI.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/NavigatorWebMIDI.h
diff --git a/Source/modules/webmidi/NavigatorWebMIDI.h b/Source/modules/webmidi/NavigatorWebMIDI.h
index 0cdba7ed5d6a0cbe64ab134be520b01515333deb..8fdbbd743eb7464f4a2b7b2fe440ce618c834fe4 100644
--- a/Source/modules/webmidi/NavigatorWebMIDI.h
+++ b/Source/modules/webmidi/NavigatorWebMIDI.h
@@ -41,16 +41,16 @@ namespace blink {
class Navigator;
-class NavigatorWebMIDI FINAL : public NoBaseWillBeGarbageCollectedFinalized<NavigatorWebMIDI>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {
+class NavigatorWebMIDI FINAL : public NoBaseWillBeGarbageCollected<NavigatorWebMIDI>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorWebMIDI);
+ DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(NavigatorWebMIDI);
public:
- virtual ~NavigatorWebMIDI();
static NavigatorWebMIDI& from(Navigator&);
static ScriptPromise requestMIDIAccess(ScriptState*, Navigator&, const Dictionary&);
ScriptPromise requestMIDIAccess(ScriptState*, const Dictionary&);
- virtual void trace(Visitor* visitor) OVERRIDE { WillBeHeapSupplement<Navigator>::trace(visitor); }
+ virtual void trace(Visitor*) OVERRIDE;
private:
NavigatorWebMIDI(LocalFrame*);

Powered by Google App Engine
This is Rietveld 408576698