Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1871)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/modules/gamepad/NavigatorGamepad.cpp

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/loader/appcache/ApplicationCacheHost.h ('K') | « Source/modules/donottrack/NavigatorDoNotTrack.cpp ('k') | Source/modules/geolocation/NavigatorGeolocation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/gamepad/NavigatorGamepad.cpp
diff --git a/Source/modules/gamepad/NavigatorGamepad.cpp b/Source/modules/gamepad/NavigatorGamepad.cpp
index a6627256e2ed276552551bd68c2ecfe8c020ccf2..37b2d01e449cbc6c1a7b819278fd3dc9579b6684 100644
--- a/Source/modules/gamepad/NavigatorGamepad.cpp
+++ b/Source/modules/gamepad/NavigatorGamepad.cpp
@@ -128,6 +128,7 @@ void NavigatorGamepad::trace(Visitor* visitor)
visitor->trace(m_webkitGamepads);
visitor->trace(m_pendingEvents);
WillBeHeapSupplement<Navigator>::trace(visitor);
+ DOMWindowProperty::trace(visitor);
}
void NavigatorGamepad::didUpdateData()
@@ -180,6 +181,9 @@ NavigatorGamepad::NavigatorGamepad(LocalFrame* frame)
NavigatorGamepad::~NavigatorGamepad()
{
+#if ENABLE(OILPAN)
+ stopUpdating();
haraken 2014/09/10 02:49:36 Why is this necessary only in oilpan?
sof 2014/09/10 05:49:40 Can't rely on willDestroyGlobalObjectInFrame() hav
+#endif
}
const char* NavigatorGamepad::supplementName()
« Source/core/loader/appcache/ApplicationCacheHost.h ('K') | « Source/modules/donottrack/NavigatorDoNotTrack.cpp ('k') | Source/modules/geolocation/NavigatorGeolocation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698