Source/modules/geolocation/NavigatorGeolocation.cpp - Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/NavigatorGeolocation.cpp

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/geolocation/NavigatorGeolocation.cpp

diff --git a/Source/modules/geolocation/NavigatorGeolocation.cpp b/Source/modules/geolocation/NavigatorGeolocation.cpp

index 49e1c0d1df2ffd989a299e0ab30497f87056d35a..d13970be17cc9b8b634afbf9a5e7219ca96fdb05 100644

--- a/Source/modules/geolocation/NavigatorGeolocation.cpp

+++ b/Source/modules/geolocation/NavigatorGeolocation.cpp

@@ -35,9 +35,7 @@ NavigatorGeolocation::NavigatorGeolocation(LocalFrame* frame)

{

}

-NavigatorGeolocation::~NavigatorGeolocation()

+DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(NavigatorGeolocation);

const char* NavigatorGeolocation::supplementName()

{

@@ -70,6 +68,7 @@ void NavigatorGeolocation::trace(Visitor* visitor)

{

visitor->trace(m_geolocation);

WillBeHeapSupplement<Navigator>::trace(visitor);

+ DOMWindowProperty::trace(visitor);

}

} // namespace blink