Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: Source/core/storage/Storage.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/storage/Storage.h
diff --git a/Source/core/storage/Storage.h b/Source/core/storage/Storage.h
index d7c4c47fb6e61c2c0e5d4924c9617f131f1c1736..c2de7baf6e953909b246b6ebf2f25f77ee14c416 100644
--- a/Source/core/storage/Storage.h
+++ b/Source/core/storage/Storage.h
@@ -40,11 +40,12 @@ namespace blink {
class ExceptionState;
class LocalFrame;
-class Storage FINAL : public RefCountedWillBeGarbageCollectedFinalized<Storage>, public ScriptWrappable, public DOMWindowProperty {
+class Storage FINAL : public RefCountedWillBeGarbageCollected<Storage>, public ScriptWrappable, public DOMWindowProperty {
DEFINE_WRAPPERTYPEINFO();
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Storage);
+ DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(Storage);
public:
static PassRefPtrWillBeRawPtr<Storage> create(LocalFrame*, PassOwnPtrWillBeRawPtr<StorageArea>);
- virtual ~Storage();
unsigned length(ExceptionState& ec) const { return m_storageArea->length(ec, m_frame); }
String key(unsigned index, ExceptionState& ec) const { return m_storageArea->key(index, ec, m_frame); }
@@ -65,7 +66,7 @@ public:
void namedPropertyEnumerator(Vector<String>&, ExceptionState&);
bool namedPropertyQuery(const AtomicString&, ExceptionState&);
- void trace(Visitor*);
+ virtual void trace(Visitor*) OVERRIDE;
private:
Storage(LocalFrame*, PassOwnPtrWillBeRawPtr<StorageArea>);

Powered by Google App Engine
This is Rietveld 408576698