Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: Source/core/plugins/DOMPluginArray.h

Issue 552733003: Oilpan: make DOMWindowProperty a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pacify GC plugin wrt LocalDOMWindow::trace() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/plugins/DOMPluginArray.h
diff --git a/Source/core/plugins/DOMPluginArray.h b/Source/core/plugins/DOMPluginArray.h
index 2c2c6afafea8fb478513546962cc5fc035bd3699..433de9f45fdf2a38a820cd8900d6625732a3f188 100644
--- a/Source/core/plugins/DOMPluginArray.h
+++ b/Source/core/plugins/DOMPluginArray.h
@@ -34,14 +34,14 @@ namespace blink {
class LocalFrame;
class PluginData;
-class DOMPluginArray FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMPluginArray>, public ScriptWrappable, public DOMWindowProperty {
+class DOMPluginArray FINAL : public RefCountedWillBeGarbageCollected<DOMPluginArray>, public ScriptWrappable, public DOMWindowProperty {
DEFINE_WRAPPERTYPEINFO();
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMPluginArray);
public:
static PassRefPtrWillBeRawPtr<DOMPluginArray> create(LocalFrame* frame)
{
return adoptRefWillBeNoop(new DOMPluginArray(frame));
}
- virtual ~DOMPluginArray();
unsigned length() const;
PassRefPtrWillBeRawPtr<DOMPlugin> item(unsigned index);
@@ -50,7 +50,7 @@ public:
void refresh(bool reload);
- void trace(Visitor*) { }
+ virtual void trace(Visitor*) OVERRIDE;
private:
explicit DOMPluginArray(LocalFrame*);

Powered by Google App Engine
This is Rietveld 408576698