[SyncFS] Test MetadataDatabaseTest using both on-memory and on-disk indexes

[SyncFS] Test MetadataDatabaseTest using both on-memory and on-disk indexes

BUG=409743
TEST=unit_tests --gtest_filter="MetadataDatabaseTest*"

Committed: https://crrev.com/9eed34b6e693049a62c5ce3eb7830705df6f9bbd
Cr-Commit-Position: refs/heads/master@{#295951}

[peria, 2014-09-08 11:24:02]

Patchset #1 (id:1) has been deleted

[peria, 2014-09-09 04:18:59]

Patchset #1 (id:20001) has been deleted

[peria, 2014-09-09 04:19:29]

peria@chromium.org changed reviewers:
+ nhiroki@chromium.org, tzik@chromium.org

[peria, 2014-09-09 04:19:29]

PTL

[tzik, 2014-09-09 08:29:50]

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
(right):

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:672:
for (size_t i = 0; i < arraysize(index_types); ++i) {
Could you split these tests to two?

[tzik, 2014-09-09 08:33:28]

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:565:
worker_task_runner->PostTask(FROM_HERE, base::Bind(
This PostTask is no longer needed, though we've not yet cleaned them up.
Could you stop adding another?

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.h (right):

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.h:142: static
void CreateOnWorkerForTesting(
What does "OnWorker" mean?

[peria, 2014-09-10 04:44:41]

Patchset #2 (id:60001) has been deleted

[peria, 2014-09-10 05:39:11]

Patchset #2 (id:80001) has been deleted

[peria, 2014-09-10 05:40:12]

Rebase changes a lot.
PTAL.

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:565:
worker_task_runner->PostTask(FROM_HERE, base::Bind(
On 2014/09/09 08:33:27, tzik wrote:
> This PostTask is no longer needed, though we've not yet cleaned them up.
> Could you stop adding another?

Acknowledged.

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.h (right):

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.h:142: static
void CreateOnWorkerForTesting(
On 2014/09/09 08:33:28, tzik wrote:
> What does "OnWorker" mean?

Renamed.

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
(right):

https://codereview.chromium.org/552723002/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:672:
for (size_t i = 0; i < arraysize(index_types); ++i) {
On 2014/09/09 08:29:50, tzik wrote:
> Could you split these tests to two?

Used parameterized test.

[nhiroki, 2014-09-10 05:58:56]

lgtm

https://codereview.chromium.org/552723002/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
(right):

https://codereview.chromium.org/552723002/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:183:
ASSERT_TRUE(database_dir_.CreateUniqueTempDir());
(Not related to this CL) We don't have to create temporary database dircectory
if we use only the in-memory env.

[peria, 2014-09-10 06:16:47]

https://codereview.chromium.org/552723002/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
(right):

https://codereview.chromium.org/552723002/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:183:
ASSERT_TRUE(database_dir_.CreateUniqueTempDir());
On 2014/09/10 05:58:55, nhiroki wrote:
> (Not related to this CL) We don't have to create temporary database dircectory
> if we use only the in-memory env.

Acknowledged.

The path of database file is checked in MetadataDatabase::OpenDatabase(),
and it seems not easy to pass it without CreateUniqueTempDir().
Let me consider how to handle it.
(I'll do in another CL, if I work for it.)

[tzik, 2014-09-10 07:43:48]

lgtm

[peria, 2014-09-10 07:45:48]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-09-10 07:51:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/552723002/100001

[commit-bot: I haz the power, 2014-09-10 09:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 09:29:34]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[peria, 2014-09-22 11:42:43]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-09-22 11:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/552723002/120001

[commit-bot: I haz the power, 2014-09-22 12:23:14]

Committed patchset #3 (id:120001) as e290937860788f0835a3eebcbf18a85f94f8d79e

[commit-bot: I haz the power, 2014-09-22 12:23:54]

Patchset 3 (id:??) landed as
https://crrev.com/9eed34b6e693049a62c5ce3eb7830705df6f9bbd
Cr-Commit-Position: refs/heads/master@{#295951}