[SyncFS] Test MetadataDatabaseTest using both on-memory and on-disk indexes

chrome/browser/sync_file_system/drive_backend/metadata_database.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/metadata_database.h"
 
 #include <algorithm>
 #include <stack>
 
 #include "base/bind.h"
@@ skipping 504 matching lines @@
   if (index->GetFileTrackerIDsByFileID(file_id).empty()) {
     index->RemoveFileMetadata(file_id);
   }
 }
 
 }  // namespace
 
 struct MetadataDatabase::CreateParam {
   scoped_refptr<base::SequencedTaskRunner> worker_task_runner;
   base::FilePath database_path;
+  bool enable_on_disk_index;
   leveldb::Env* env_override;
 
   CreateParam(
       const scoped_refptr<base::SequencedTaskRunner>& worker_task_runner,
       const base::FilePath& database_path,
+      bool enable_on_disk_index,
       leveldb::Env* env_override)
       : worker_task_runner(worker_task_runner),
         database_path(database_path),
+        enable_on_disk_index(enable_on_disk_index),
         env_override(env_override) {}
 };
 
 // static
 void MetadataDatabase::Create(
     const scoped_refptr<base::SequencedTaskRunner>& worker_task_runner,
     const base::FilePath& database_path,
     leveldb::Env* env_override,
     const CreateCallback& callback) {
+  bool enable_on_disk_index = !CommandLine::ForCurrentProcess()->HasSwitch(
+      kDisableMetadataDatabaseOnDisk);
+
+  worker_task_runner->PostTask(FROM_HERE, base::Bind(
+      &MetadataDatabase::CreateOnWorkerTaskRunner,
+      base::Passed(make_scoped_ptr(new CreateParam(
+          worker_task_runner,
+          database_path,
+          enable_on_disk_index,
+          env_override))),
+      callback));
+}
+
+// static
+void MetadataDatabase::CreateOnWorkerForTesting(
+    const scoped_refptr<base::SequencedTaskRunner>& worker_task_runner,
+    const base::FilePath& database_path,
+    bool enable_on_disk_index,
+    leveldb::Env* env_override,
+    const CreateCallback& callback) {
   worker_task_runner->PostTask(FROM_HERE, base::Bind(

[tzik, 2014/09/09 08:33:27]

This PostTask is no longer needed, though we've not yet cleaned them up.
Could you stop adding another?

[peria, 2014/09/10 05:40:12]

Acknowledged.

       &MetadataDatabase::CreateOnWorkerTaskRunner,
       base::Passed(make_scoped_ptr(new CreateParam(
           worker_task_runner,
           database_path,
+          enable_on_disk_index,
           env_override))),
       callback));
 }
 
 // static
 SyncStatusCode MetadataDatabase::CreateForTesting(
     scoped_ptr<LevelDBWrapper> db,
     bool enable_on_disk_index,
     scoped_ptr<MetadataDatabase>* metadata_database_out) {
   scoped_ptr<MetadataDatabase> metadata_database(
@@ skipping 861 matching lines @@
       weak_ptr_factory_(this) {
   DCHECK(worker_task_runner.get());
 }
 
 // static
 void MetadataDatabase::CreateOnWorkerTaskRunner(
     scoped_ptr<CreateParam> create_param,
     const CreateCallback& callback) {
   DCHECK(create_param->worker_task_runner->RunsTasksOnCurrentThread());
 
-  bool enable_on_disk_index = !CommandLine::ForCurrentProcess()->HasSwitch(
-      kDisableMetadataDatabaseOnDisk);
   scoped_ptr<MetadataDatabase> metadata_database(
       new MetadataDatabase(create_param->worker_task_runner,
                            create_param->database_path,
-                           enable_on_disk_index,
+                           create_param->enable_on_disk_index,
                            create_param->env_override));
 
   SyncStatusCode status = metadata_database->Initialize();
   if (status == SYNC_DATABASE_ERROR_FAILED) {
     // Delete the previous instance to avoid creating a LevelDB instance for
     // the same path.
     metadata_database.reset();
 
     metadata_database.reset(
         new MetadataDatabase(create_param->worker_task_runner,
                              create_param->database_path,
-                             enable_on_disk_index,
+                             create_param->enable_on_disk_index,
                              create_param->env_override));
     status = metadata_database->Initialize();
   }
 
   if (status != SYNC_STATUS_OK)
     metadata_database.reset();
 
   if (metadata_database)
     metadata_database->DetachFromSequence();
   create_param->worker_task_runner->PostTask(
@@ skipping 530 matching lines @@
       return false;
 
   if (!parents.empty())
     return false;
 
   return true;
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system