Issue 552383002: Detect presence of dwrite_1.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552383002: Detect presence of dwrite_1.h. (Closed)

Created:
6 years, 3 months ago by bungeman-skia

Modified:
6 years, 3 months ago

Reviewers:
gw280, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Detect presence of dwrite_1.h. This introduces the SK_HAS_DWRITE_1_H define which may be set at build time or will be true when WINVER_MAXVER >= 0x0602 . The dwrite_1.h header is available starting in Windows SDK 8.0. This change supports users who must still use Windows SDK 7.0. It also allows for easier local testing of the older interfaces on newer versions of Windows. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1053652 Committed: https://skia.googlesource.com/skia/+/f548444684b9c96f7717aebe645944af4f95d650

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -19 lines)			Patch
M	gyp/common_conditions.gypi	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ports/SkScalerContext_win_dw.cpp	View	3 chunks	+24 lines, -16 lines	0 comments	Download
M	src/ports/SkTypeface_win_dw.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	src/utils/win/SkDWrite.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bungeman-skia

See also https://codereview.chromium.org/537633002/

6 years, 3 months ago (2014-09-09 15:18:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/552383002/1

6 years, 3 months ago (2014-09-10 14:41:11 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 14:49:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as f548444684b9c96f7717aebe645944af4f95d650

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages