Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 552353002: Fix un-selecting user cert for VPN. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix un-selecting user cert for VPN. Bug was introduced in https://codereview.chromium.org/421113002 . BUG= Committed: https://crrev.com/90623d7d2dbeb04c01859320db5311ec8c8311f3 Cr-Commit-Position: refs/heads/master@{#293948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pneubeck (no reviews)
This bug should have made it into R38. Not sure whether it's worth merging. I'm ...
6 years, 3 months ago (2014-09-09 15:16:20 UTC) #2
stevenjb
lgtm
6 years, 3 months ago (2014-09-09 15:32:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/552353002/1
6 years, 3 months ago (2014-09-09 15:34:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 92c6f85cac91d0677d3814e52a29d9469939e4d7
6 years, 3 months ago (2014-09-09 16:17:32 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90623d7d2dbeb04c01859320db5311ec8c8311f3
Cr-Commit-Position: refs/heads/master@{#293948}

Powered by Google App Engine
This is Rietveld 408576698