Use correct slot id for client certs in network config.

Use correct slot id for client certs in network config.

- Now all client cert related Shill properties are set through client_cert_util.*
- Slot id is obtained from the slot in which the private key is stored
- All client cert pattern resolution now happens in ClientCertResolver

BUG=358366
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286583

[pneubeck (no reviews), 2014-07-27 16:19:22]

The primary reason for this CL is to use the correct slot id for client cert
configuration.
I used this as an excuse to clean up the client cert configuration in general.

[pneubeck (no reviews), 2014-07-27 16:19:23]

The primary reason for this CL is to use the correct slot id for client cert
configuration.
I used this as an excuse to clean up the client cert configuration in general.

[pneubeck (no reviews), 2014-07-27 16:20:25]

+Toni, since he changed CertLoader for multiprofile before and this might affect
multiprofile as well.

[stevenjb, 2014-07-29 18:31:10]

LGTM

https://codereview.chromium.org/421113002/diff/60001/chromeos/network/client_...
File chromeos/network/client_cert_resolver.cc (right):

https://codereview.chromium.org/421113002/diff/60001/chromeos/network/client_...
chromeos/network/client_cert_resolver.cc:271: base::DictionaryValue*
config_properties) {
nit: name this shill_properties maybe? I tend to associate 'config' with ONC.

https://codereview.chromium.org/421113002/diff/60001/chromeos/network/network...
File chromeos/network/network_connection_handler_unittest.cc (right):

https://codereview.chromium.org/421113002/diff/60001/chromeos/network/network...
chromeos/network/network_connection_handler_unittest.cc:236: module,
pkcs12_data, base::string16(), false, &loaded_certs)) {
nit: ... != net::OK

[pneubeck (no reviews), 2014-07-30 18:22:46]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-07-30 18:23:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/421113002/100001

[tbarzic, 2014-07-30 18:33:54]

On 2014/07/30 18:23:44, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/pneubeck@chromium.org/421113002/100001

fwiw LGTM :)

[commit-bot: I haz the power, 2014-07-30 19:40:14]

Change committed as 286583