Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 552323003: Changing the order of initialization WeakPtrFactory (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
stevenjb, DaveMoore
CC:
lgombos, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing the order of initialization WeakPtrFactory Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/945f5aa3a9b0f3c4e43329d1ada1fb8b64b76d73 Cr-Commit-Position: refs/heads/master@{#294319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M chromeos/audio/cras_audio_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/auth/online_attempt.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/login/auth/online_attempt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/tpm_password_fetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/tpm_password_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
stevenjb@chromium.org: Please review changes in src/chromeos folder davemoore@chromium.org: Please review changes in src/chromeos folder PTAL
6 years, 3 months ago (2014-09-10 04:48:32 UTC) #2
stevenjb
lgtm
6 years, 3 months ago (2014-09-10 17:47:09 UTC) #3
MRV
On 2014/09/10 17:47:09, stevenjb wrote: > lgtm Thanks Mr. Stevenjb for LGTM
6 years, 3 months ago (2014-09-11 02:49:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552323003/1
6 years, 3 months ago (2014-09-11 02:50:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1011e78e82091490b01c2fcbc9030d1309e21650
6 years, 3 months ago (2014-09-11 03:54:52 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 04:00:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/945f5aa3a9b0f3c4e43329d1ada1fb8b64b76d73
Cr-Commit-Position: refs/heads/master@{#294319}

Powered by Google App Engine
This is Rietveld 408576698