chromeos/audio/cras_audio_handler.cc - Issue 552323003: Changing the order of initialization WeakPtrFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/audio/cras_audio_handler.cc

Issue 552323003: Changing the order of initialization WeakPtrFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/audio/cras_audio_handler.cc

diff --git a/chromeos/audio/cras_audio_handler.cc b/chromeos/audio/cras_audio_handler.cc

index 295f28089aa04e3dcde7e20bba82a36b855aed6f..1907190f0ba0e52075ae06e254b6ce3cb27aaead 100644

--- a/chromeos/audio/cras_audio_handler.cc

+++ b/chromeos/audio/cras_audio_handler.cc

@@ -327,7 +327,6 @@ void CrasAudioHandler::LogErrors() {

CrasAudioHandler::CrasAudioHandler(

scoped_refptr<AudioDevicesPrefHandler> audio_pref_handler)

: audio_pref_handler_(audio_pref_handler),

- weak_ptr_factory_(this),

output_mute_on_(false),

input_mute_on_(false),

output_volume_(0),

@@ -338,7 +337,8 @@ CrasAudioHandler::CrasAudioHandler(

has_alternative_output_(false),

output_mute_locked_(false),

input_mute_locked_(false),

- log_errors_(false) {

+ log_errors_(false),

+ weak_ptr_factory_(this) {

if (!audio_pref_handler.get())

return;

// If the DBusThreadManager or the CrasAudioClient aren't available, there

« no previous file with comments | « chromeos/audio/cras_audio_handler.h ('k') | chromeos/login/auth/online_attempt.h » ('j') | no next file with comments »