Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(426)

Issue 5523003: Part 1 of merges for Chromium bug #64589... (Closed)

Created:
9 years, 11 months ago by Vangelis Kokkevis
Modified:
9 years, 4 months ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Part 1 of merges for Chromium bug #64589 Merge 72954 - 2010-11-29 Vangelis Kokkevis <vangelis@chromium.org>; Reviewed by Simon Fraser. Provide more fine grained control to ports over when to turn on accelerated compositing. https://bugs.webkit.org/show_bug.cgi?id=49998 As part of this change, the old hasAcceleratedCompositing method on the ChromeClient has now been replaced by allowedCompositingTriggers which returns a bitfield of all the features which can trigger the compositor. * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowedCompositingTriggers): * src/ChromeClientImpl.h: 2010-11-29 Vangelis Kokkevis <vangelis@chromium.org>; Reviewed by Simon Fraser. Provide more fine grained control to ports over when to turn on accelerated compositing. https://bugs.webkit.org/show_bug.cgi?id=49998 As part of this change, the old hasAcceleratedCompositing method on the ChromeClient has now been replaced by allowedCompositingTriggers which returns a bitfield of all the features which can trigger the compositor. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::allowedCompositingTriggers): * WebCoreSupport/ChromeClientQt.h: 2010-11-30 Vangelis Kokkevis <vangelis@chromium.org>; Reviewed by Simon Fraser. Provide more fine grained control to ports over when to turn on accelerated compositing. https://bugs.webkit.org/show_bug.cgi?id=49998 The RenderLayerCompositor now checks with the chrome client whether 3d transforms, video, plugins, canvas and animation require switching over to the composited path. Layers that overlap composited content will still turn into composited layers regardless of the setting. * css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval): * page/ChromeClient.h: (WebCore::ChromeClient::allowedCompositingTriggers): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::canRender3DTransforms): (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform): * rendering/RenderLayer.h: * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateLayerTransform): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): (WebCore::RenderLayerCompositor::canRender3DTransforms): (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForTransform): (WebCore::RenderLayerCompositor::requiresCompositingForVideo): (WebCore::RenderLayerCompositor::requiresCompositingForCanvas): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): (WebCore::RenderLayerCompositor::requiresCompositingForAnimation): * rendering/RenderLayerCompositor.h: TBR=vangelis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -18 lines) Patch
M WebCore/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/page/ChromeClient.h View 1 chunk +13 lines, -0 lines 0 comments Download
M WebCore/rendering/RenderLayer.h View 1 chunk +3 lines, -1 line 0 comments Download
M WebCore/rendering/RenderLayer.cpp View 3 chunks +11 lines, -2 lines 0 comments Download
M WebCore/rendering/RenderLayerBacking.cpp View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/rendering/RenderLayerCompositor.h View 3 chunks +6 lines, -1 line 0 comments Download
M WebCore/rendering/RenderLayerCompositor.cpp View 9 chunks +28 lines, -5 lines 0 comments Download
M WebKit/chromium/src/ChromeClientImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M WebKit/chromium/src/ChromeClientImpl.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M WebKit/qt/WebCoreSupport/ChromeClientQt.h View 1 chunk +1 line, -1 line 0 comments Download
M WebKit/qt/WebCoreSupport/ChromeClientQt.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Vangelis Kokkevis
9 years, 11 months ago (2010-12-02 17:41:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698