Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 552227: Utility to output digests in format suitable for RSA signatures. (Closed)

Created:
10 years, 11 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Utility to output digests in format suitable for RSA signatures. The current stable version of OpenSSL(0.9.8d) does not support RSA signature with SHA-256 and SHA-512 message digests. This utility outputs the hash of file data in a format suitable for use with the "openssl" command-line tool fir generating RSA signatures. Also modified the tests to use this to generate RSA signature rather than "openssl pkeyutl" which is not supported on current stable version of OpenSSL.

Patch Set 1 #

Patch Set 2 : 80 char fix. #

Total comments: 4

Patch Set 3 : Nit fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -22 lines) Patch
src/platform/vboot_reference/crypto/genpadding.sh View 7 chunks +64 lines, -9 lines 0 comments Download
src/platform/vboot_reference/crypto/padding.c View 3 chunks +60 lines, -0 lines 0 comments Download
src/platform/vboot_reference/include/padding.h View 1 chunk +3 lines, -0 lines 0 comments Download
src/platform/vboot_reference/tests/Makefile View 2 chunks +5 lines, -2 lines 0 comments Download
src/platform/vboot_reference/tests/run_tests.sh View 1 2 chunks +11 lines, -11 lines 0 comments Download
src/platform/vboot_reference/tests/signature_digest.h View 1 chunk +16 lines, -0 lines 0 comments Download
src/platform/vboot_reference/tests/signature_digest.c View 1 2 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gauravsh
10 years, 11 months ago (2010-01-29 02:28:11 UTC) #1
Chris Masone
lgtm, with nits http://codereview.chromium.org/552227/diff/1001/2006 File src/platform/vboot_reference/tests/signature_digest.c (right): http://codereview.chromium.org/552227/diff/1001/2006#newcode26 src/platform/vboot_reference/tests/signature_digest.c:26: int digestinfo_size = digestinfo_size_map[algorithm]; why arent ...
10 years, 11 months ago (2010-01-29 03:33:15 UTC) #2
gauravsh
10 years, 11 months ago (2010-01-29 03:43:01 UTC) #3
http://codereview.chromium.org/552227/diff/1001/2006
File src/platform/vboot_reference/tests/signature_digest.c (right):

http://codereview.chromium.org/552227/diff/1001/2006#newcode26
src/platform/vboot_reference/tests/signature_digest.c:26: int digestinfo_size =
digestinfo_size_map[algorithm];
On 2010/01/29 03:33:15, cmasone wrote:
> why arent the above const as well?

Done.

http://codereview.chromium.org/552227/diff/1001/2006#newcode36
src/platform/vboot_reference/tests/signature_digest.c:36: uint8_t *digest =
NULL, *signature = NULL;
On 2010/01/29 03:33:15, cmasone wrote:
> do these on separate lines.  Also...I used to do this too, but sometimes you
put
> the * next to the var name, and sometimes next to the type.  Can you pick one
> and stick with it?

Yes, from now on I am sticking to the type name. Fixed.

Powered by Google App Engine
This is Rietveld 408576698