Chromium Code Reviews
Help | Chromium Project | Sign in
(92)

Issue 552203: Use the newly added CheckLicense() canned check to verify license boiler plate on source files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by M-A Ruel (OOO until Aug 10)
Modified:
4 years, 2 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use the newly added CheckLicense() canned check to verify license boiler plate on source files. Don't check for the year since there was no clear concensus about systematically updating the year on every change. TEST=none BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M PRESUBMIT.py View 3 chunks +21 lines, -18 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
M-A Ruel (OOO until Aug 10)
5 years, 6 months ago (2010-01-27 23:06:55 UTC) #1
Peter Kasting
Not every file has a license, e.g. .grd files don't. Is this careful about the ...
5 years, 6 months ago (2010-01-27 23:17:08 UTC) #2
M-A Ruel (OOO until Aug 10)
Adding Nicolas for the correctness. The sources white list is DEFAULT_WHITE_LIST in http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_support.py?view=markup I just ...
5 years, 6 months ago (2010-01-27 23:24:14 UTC) #3
Nicolas Sylvain
5 years, 6 months ago (2010-01-27 23:38:36 UTC) #4
On Wed, Jan 27, 2010 at 3:24 PM, <maruel@chromium.org> wrote:

> Adding Nicolas for the correctness.
>
> The sources white list is DEFAULT_WHITE_LIST in
>
>
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_suppo...
>
> I just realized it includes files without an extension, which is quite bad.
> This, *.json and *.txt should be removed from the white list before
> checking
> this change in. What do you think?

I really have no idea

>
>
> http://codereview.chromium.org/552203
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5