Issue 552203: Use the newly added CheckLicense() canned check to verify license boiler plate on source files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552203: Use the newly added CheckLicense() canned check to verify license boiler plate on source files. (Closed)

Created:
10 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Use the newly added CheckLicense() canned check to verify license boiler plate on source files. Don't check for the year since there was no clear concensus about systematically updating the year on every change. TEST=none BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37361

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -18 lines)			Patch
	M	PRESUBMIT.py	View		3 chunks	+21 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Not every file has a license, e.g. .grd files don't. Is this careful about the ...

10 years, 11 months ago (2010-01-27 23:17:08 UTC) #2

M-A Ruel

Adding Nicolas for the correctness. The sources white list is DEFAULT_WHITE_LIST in http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_support.py?view=markup I just ...

10 years, 11 months ago (2010-01-27 23:24:14 UTC) #3

Nicolas Sylvain

10 years, 11 months ago (2010-01-27 23:38:36 UTC) #4

On Wed, Jan 27, 2010 at 3:24 PM, <maruel@chromium.org> wrote:

> Adding Nicolas for the correctness.
>
> The sources white list is DEFAULT_WHITE_LIST in
>
>
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_suppo...
>
> I just realized it includes files without an extension, which is quite bad.
> This, *.json and *.txt should be removed from the white list before
> checking
> this change in. What do you think?

I really have no idea

>
>
> http://codereview.chromium.org/552203
>

Expand Messages | Collapse Messages