Add ONC 'Source' configuration property

chromeos/network/network_util.cc

Index: chromeos/network/network_util.cc
diff --git a/chromeos/network/network_util.cc b/chromeos/network/network_util.cc
index c090444d2e495e2e873f2ea1796a677fe0798ff0..1030e2076b2edf5492660219eb91dc5a55908001 100644
--- a/chromeos/network/network_util.cc
+++ b/chromeos/network/network_util.cc
@@ -147,8 +147,9 @@ scoped_ptr<base::DictionaryValue> TranslateNetworkStateToONC(
   network->GetStateProperties(&shill_dictionary);
 
   scoped_ptr<base::DictionaryValue> onc_dictionary =
-      TranslateShillServiceToONCPart(
-          shill_dictionary, &onc::kNetworkWithStateSignature);
+      TranslateShillServiceToONCPart(shill_dictionary,
+                                     ::onc::ONC_SOURCE_NONE,

[pneubeck (no reviews), 2014/09/10 10:49:38]

Ohoh, note that this will lead to incorrect 'Source' values!

The way you implemented it, the onc_source argument is mandatory. Either we
change the implementation to make the argument optional, i.e. if it's not
provided the 'Source' property will not be added.
Or, the argument must always be correctly provided.

[stevenjb, 2014/09/10 17:32:15]

I guess I was assuming that we wouldn't care in the places we always passed in
None, but you are right, it would be better to explicitly pass 'unknown. I think
it is more clear to add UNKNOWN as an enum entry than doing something like
passing a pointer that could be NULL.

+                                     &onc::kNetworkWithStateSignature);
   return onc_dictionary.Pass();
 }