Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/bisect-perf-regression_test.py

Issue 552013008: Replace "git svn" with "git footers" commands to get commit position or svn revision. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/auto_bisect/source_control.py ('K') | « tools/auto_bisect/source_control.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression_test.py
diff --git a/tools/bisect-perf-regression_test.py b/tools/bisect-perf-regression_test.py
index 16a3f13f0a513c278f933f12c66782fe524c423e..e00a761994b0173b57a900c4cd23645d416c875d 100644
--- a/tools/bisect-perf-regression_test.py
+++ b/tools/bisect-perf-regression_test.py
@@ -266,6 +266,21 @@ class BisectPerfRegressionTest(unittest.TestCase):
self.assertEqual(291467,
bisect_instance.source_control.SVNFindRev(svn_git_rev))
qyearsley 2014/09/10 01:04:14 What about SVN revs from before the Cr-Commit-Posi
prasadv 2014/09/10 17:16:33 git footers will find both svn and commit position
qyearsley 2014/09/10 17:49:53 Nice, I just tested this, it works. $ git footers
+ svn_v8_rev = '21d700eedcdd6570eff22ece724b63a5eefe78cb'
+ depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'v8')
+ self.assertEqual(
+ 23634,
+ bisect_instance.source_control.SVNFindRev(svn_v8_rev, depot_path))
+
+ svn_wk_rev = 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61'
+ depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'third_party',
+ 'WebKit')
+ self.assertEqual(
+ 181660,
+ bisect_instance.source_control.SVNFindRev(svn_wk_rev, depot_path))
qyearsley 2014/09/10 01:04:14 Each of these could be separate test methods --
prasadv 2014/09/10 17:16:33 Done.
+
+
+
qyearsley 2014/09/10 01:04:14 Formatting: One blank line between methods.
prasadv 2014/09/10 17:16:33 Done.
def testUpdateDepsContent(self):
bisect_instance = _GetBisectPerformanceMetricsInstance()
deps_file = 'DEPS'
« tools/auto_bisect/source_control.py ('K') | « tools/auto_bisect/source_control.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698