Replace "git svn" with "git footers" commands to get commit position or svn revision.

tools/bisect-perf-regression_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import unittest
 
 from auto_bisect import source_control as source_control_module
 
@@ skipping 238 matching lines @@
     script.
     """
     bisect_instance = _GetBisectPerformanceMetricsInstance()
     results = bisect_instance.Run(bisect_instance.opts.command,
                                   bisect_instance.opts.bad_revision,
                                   bisect_instance.opts.good_revision,
                                   bisect_instance.opts.metric)
     bisect_instance.FormatAndPrintResults(results)
 
   def testSVNFindRev(self):
     """Determine numerical SVN revision or Commit Position."""

[qyearsley, 2014/09/10 01:04:14]

Note, this docstring doesn't really describe what the test does, it describes
what the test verifies... maybe this docstring isn't necessary?

Also, this test relies on being run in a git repo with a certain state, since it
actually runs the git commands, right?

[prasadv, 2014/09/10 17:16:33]

It should run in a directory where that git hash belongs, eg, run in src for
chromium sha, in src/v8 directory for V8 git hashes.
I don't think we need any special state other than running theses test on git
hash revision greater than the ones used in this test.

[qyearsley, 2014/09/10 17:49:53]

Alright, sounds good.

     bisect_instance = _GetBisectPerformanceMetricsInstance()
     cp_git_rev = '7017a81991de983e12ab50dfc071c70e06979531'
     self.assertEqual(291765,
                      bisect_instance.source_control.SVNFindRev(cp_git_rev))
 
     svn_git_rev = 'e6db23a037cad47299a94b155b95eebd1ee61a58'
     self.assertEqual(291467,
                      bisect_instance.source_control.SVNFindRev(svn_git_rev))

[qyearsley, 2014/09/10 01:04:14]

What about SVN revs from before the Cr-Commit-Position footer started getting
added to the commit messages?

For example, crrev.com/280000?

Since you're not running "git svn find-rev" anymore, I'd expect this to fail
now. (Which may be fine, since it will only fail for relatively old revisions.)

[prasadv, 2014/09/10 17:16:33]

git footers will find both svn and commit position.

[qyearsley, 2014/09/10 17:49:53]

Nice, I just tested this, it works.
$ git footers --position-num 89aa0c99
280000

 
+    svn_v8_rev = '21d700eedcdd6570eff22ece724b63a5eefe78cb'
+    depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'v8')
+    self.assertEqual(
+        23634,
+        bisect_instance.source_control.SVNFindRev(svn_v8_rev, depot_path))
+
+    svn_wk_rev = 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61'
+    depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'third_party',
+                              'WebKit')
+    self.assertEqual(
+        181660,
+        bisect_instance.source_control.SVNFindRev(svn_wk_rev, depot_path))

[qyearsley, 2014/09/10 01:04:14]

Each of these could be separate test methods -- 

for example,

testSVNFindRev_Webkit(self):
  svn_wk_rev = 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61'
  depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'third_party',
      'WebKit')
  self.assertEqual(
      181660,
      bisect_instance.source_control.SVNFindRev(svn_wk_rev, depot_path))

[prasadv, 2014/09/10 17:16:33]

Done.

+
+
+

[qyearsley, 2014/09/10 01:04:14]

Formatting: One blank line between methods.

[prasadv, 2014/09/10 17:16:33]

Done.

   def testUpdateDepsContent(self):
     bisect_instance = _GetBisectPerformanceMetricsInstance()
     deps_file = 'DEPS'
     # We are intentionally reading DEPS file contents instead of string literal
     # with few lines from DEPS because to check if the format we are expecting
     # to search is not changed in DEPS content.
     # TODO (prasadv): Add a separate test to validate the DEPS contents with the
     # format that bisect script expects.
     deps_contents = bisect_perf_module.ReadStringFromFile(deps_file)
     deps_key = 'v8_revision'
     depot = 'v8'
     git_revision = 'a12345789a23456789a123456789a123456789'
     updated_content = bisect_instance.UpdateDepsContents(
         deps_contents, depot, git_revision, deps_key)
     self.assertIsNotNone(updated_content)
     ss = re.compile('["\']%s["\']: ["\']%s["\']' % (deps_key, git_revision))
     self.assertIsNotNone(re.search(ss, updated_content))
 
 
 if __name__ == '__main__':
   unittest.main()