Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 551883003: Update test_runner.py to use page_set names rather than paths. (Closed)

Created:
6 years, 3 months ago by ariblue
Modified:
6 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update test_runner.py to use page_set names rather than paths. This allows us to get rid of the page_set dependency in discover.py, since it eliminates the last call to IsPageSetFile. NOTE: reverting this patch will require reverting https://codereview.chromium.org/555843003/ if that patch is landed. BUG= Committed: https://crrev.com/70712e0cd3f8d7d6c0b32f705a8f43bbeaae0374 Cr-Commit-Position: refs/heads/master@{#293973}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M tools/telemetry/telemetry/core/discover.py View 2 chunks +0 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/core/discover_unittest.py View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 2 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ariblue
6 years, 3 months ago (2014-09-08 23:55:31 UTC) #2
nednguyen
lgtm Thanks Ari! I think we can remove the page_set.PageSet.FromFile since this should be the ...
6 years, 3 months ago (2014-09-09 02:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ariblue@google.com/551883003/20001
6 years, 3 months ago (2014-09-09 17:13:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as be16bf7ec01d2c1dae65bd9549918a3422235b7e
6 years, 3 months ago (2014-09-09 18:39:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70712e0cd3f8d7d6c0b32f705a8f43bbeaae0374
Cr-Commit-Position: refs/heads/master@{#293973}

Powered by Google App Engine
This is Rietveld 408576698