Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: tools/telemetry/telemetry/core/discover_unittest.py

Issue 551883003: Update test_runner.py to use page_set names rather than paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/discover.py ('k') | tools/telemetry/telemetry/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/discover_unittest.py
diff --git a/tools/telemetry/telemetry/core/discover_unittest.py b/tools/telemetry/telemetry/core/discover_unittest.py
index 3390b2e1b946bd74a1133be91580ac4fd2dfb190..ba2bf70107e218d90e0e816b4bc8caea7a1016f4 100644
--- a/tools/telemetry/telemetry/core/discover_unittest.py
+++ b/tools/telemetry/telemetry/core/discover_unittest.py
@@ -51,17 +51,3 @@ class DiscoverTest(unittest.TestCase):
'dummy_exception_impl2': 'DummyExceptionImpl2',
}
self.assertEqual(actual_classes, expected_classes)
-
- def testIsPageSetFile(self):
- top_10_ps_dir = os.path.join(util.GetChromiumSrcDir(),
- 'tools/perf/page_sets/top_10.py')
- top_10_json_data = os.path.join(util.GetChromiumSrcDir(),
- 'tools/perf/page_sets/data/top_10.json')
- test_ps_dir = os.path.join(util.GetTelemetryDir(),
- 'unittest_data/test_page_set.py')
- page_set_dir = os.path.join(util.GetTelemetryDir(),
- 'telemetry/page/page_set.py')
- self.assertTrue(discover.IsPageSetFile(top_10_ps_dir))
- self.assertFalse(discover.IsPageSetFile(top_10_json_data))
- self.assertFalse(discover.IsPageSetFile(test_ps_dir))
- self.assertFalse(discover.IsPageSetFile(page_set_dir))
« no previous file with comments | « tools/telemetry/telemetry/core/discover.py ('k') | tools/telemetry/telemetry/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698