Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 551873002: Fix number of buckets in AsyncDNS.ServerCount and ServerFailureIndex UMA histograms. (Closed)

Created:
6 years, 3 months ago by timvolodine
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix number of buckets in AsyncDNS.ServerCount and ServerFailureIndex UMA histograms. Fix number of buckets in AsyncDNS.ServerCount and SyncDNS.ServerFailureIndex UMA histograms. Currently the value 9 falls in the bucket with value 8 which is confusing. Results can be checked on uma.googleplex.com. BUG= Committed: https://crrev.com/23be9745d2dcf3730f0ed18f5c835478690eab46 Cr-Commit-Position: refs/heads/master@{#296950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/dns/dns_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
timvolodine
6 years, 3 months ago (2014-09-08 15:51:06 UTC) #2
mef
lgtm, although I'm a bit surprised that we see DNS configs with 8-9 servers.
6 years, 3 months ago (2014-09-08 16:07:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/551873002/1
6 years, 2 months ago (2014-09-26 15:07:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9cbe8c178866f3bc91d09a22b88732232eee6554
6 years, 2 months ago (2014-09-26 15:44:07 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 15:44:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23be9745d2dcf3730f0ed18f5c835478690eab46
Cr-Commit-Position: refs/heads/master@{#296950}

Powered by Google App Engine
This is Rietveld 408576698