Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: net/dns/dns_session.cc

Issue 551873002: Fix number of buckets in AsyncDNS.ServerCount and ServerFailureIndex UMA histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_session.cc
diff --git a/net/dns/dns_session.cc b/net/dns/dns_session.cc
index ea8b6a142746bcc391b60e7ba20952e45e1636f6..d6992f1c72aacf1f17103478093ebaa77e68f256 100644
--- a/net/dns/dns_session.cc
+++ b/net/dns/dns_session.cc
@@ -89,7 +89,7 @@ DnsSession::DnsSession(const DnsConfig& config,
server_index_(0) {
socket_pool_->Initialize(&config_.nameservers, net_log);
UMA_HISTOGRAM_CUSTOM_COUNTS(
- "AsyncDNS.ServerCount", config_.nameservers.size(), 0, 10, 10);
+ "AsyncDNS.ServerCount", config_.nameservers.size(), 0, 10, 11);
for (size_t i = 0; i < config_.nameservers.size(); ++i) {
server_stats_.push_back(new ServerStats(config_.timeout,
rtt_buckets_.Pointer()));
@@ -139,7 +139,7 @@ unsigned DnsSession::NextGoodServerIndex(unsigned server_index) {
void DnsSession::RecordServerFailure(unsigned server_index) {
UMA_HISTOGRAM_CUSTOM_COUNTS(
- "AsyncDNS.ServerFailureIndex", server_index, 0, 10, 10);
+ "AsyncDNS.ServerFailureIndex", server_index, 0, 10, 11);
++(server_stats_[server_index]->last_failure_count);
server_stats_[server_index]->last_failure = base::Time::Now();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698