Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 551863003: Fix a crash which occurs while translating the windows message WM_DEADCHAR to our events format. (Closed)

Created:
6 years, 3 months ago by ananta
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a crash which occurs while translating the windows message WM_DEADCHAR to our events format. The crash occurs because the EventTypeFromNative helper function on windows does not handle this message and returns ET_UNKNOWN as the type leading to a CHECK later on. The WM_DEADCHAR message is posted while translating certain character sequences in the context of WM_KEYUP. Fix is to return the type for WM_DEADCHAR as ET_KEY_RELEASED. BUG=411811 Committed: https://crrev.com/79359cecd0ce534e356e3380a4d7e4dc4a29e07b Cr-Commit-Position: refs/heads/master@{#293859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/events/win/events_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ananta
6 years, 3 months ago (2014-09-08 19:12:30 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-08 20:37:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/551863003/1
6 years, 3 months ago (2014-09-08 22:31:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/551863003/1
6 years, 3 months ago (2014-09-09 03:06:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as fee7be74b893ce264bec57a1493f08e6c23ff3a6
6 years, 3 months ago (2014-09-09 05:46:33 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:50:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79359cecd0ce534e356e3380a4d7e4dc4a29e07b
Cr-Commit-Position: refs/heads/master@{#293859}

Powered by Google App Engine
This is Rietveld 408576698