Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: ui/events/win/events_win.cc

Issue 551863003: Fix a crash which occurs while translating the windows message WM_DEADCHAR to our events format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/win/events_win.cc
diff --git a/ui/events/win/events_win.cc b/ui/events/win/events_win.cc
index 6365c76b673900248bc06b8cef96849a0d87ddfa..9434b2b4e390dc60d2893eb3d16c3d0e4a25e2ec 100644
--- a/ui/events/win/events_win.cc
+++ b/ui/events/win/events_win.cc
@@ -151,6 +151,10 @@ EventType EventTypeFromNative(const base::NativeEvent& native_event) {
case WM_SYSKEYDOWN:
case WM_CHAR:
return ET_KEY_PRESSED;
+ // The WM_DEADCHAR message is posted to the window with the keyboard focus
+ // when a WM_KEYUP message is translated. This happens for special keyboard
+ // sequences.
+ case WM_DEADCHAR:
case WM_KEYUP:
case WM_SYSKEYUP:
return ET_KEY_RELEASED;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698