Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 551833002: Disable failing TouchFeedback tests. (Closed)

Created:
6 years, 3 months ago by jonross
Modified:
6 years, 3 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable failing TouchFeedback tests. Disable WebNotificationTrayTest.TouchFeedback and TouchFeedbackCancellation which are failing on ASAN machines. TBR=skuhne@chromium.org BUG=411881 Committed: https://crrev.com/6c0caa104a6862e8b8b5ebd541ad7ab82338c5b0 Cr-Commit-Position: refs/heads/master@{#293724}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jonross
Rob could you provide the LGTM for this disable?
6 years, 3 months ago (2014-09-08 13:36:34 UTC) #2
jonross
Rob could you provide the LGTM for this disable?
6 years, 3 months ago (2014-09-08 13:36:34 UTC) #3
flackr
LGTM with nits: Add BUG=811881 to CL description. https://codereview.chromium.org/551833002/diff/1/ash/system/web_notification/web_notification_tray_unittest.cc File ash/system/web_notification/web_notification_tray_unittest.cc (right): https://codereview.chromium.org/551833002/diff/1/ash/system/web_notification/web_notification_tray_unittest.cc#newcode481 ash/system/web_notification/web_notification_tray_unittest.cc:481: // ...
6 years, 3 months ago (2014-09-08 13:40:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/551833002/1
6 years, 3 months ago (2014-09-08 13:43:55 UTC) #7
jonross
https://codereview.chromium.org/551833002/diff/1/ash/system/web_notification/web_notification_tray_unittest.cc File ash/system/web_notification/web_notification_tray_unittest.cc (right): https://codereview.chromium.org/551833002/diff/1/ash/system/web_notification/web_notification_tray_unittest.cc#newcode481 ash/system/web_notification/web_notification_tray_unittest.cc:481: // TODO(jonross): These tests are failing on ASAN bots, ...
6 years, 3 months ago (2014-09-08 13:55:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/551833002/20001
6 years, 3 months ago (2014-09-08 13:56:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as eec5d42035d08a39c703aca2a9959a0205b818a5
6 years, 3 months ago (2014-09-08 14:53:51 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c0caa104a6862e8b8b5ebd541ad7ab82338c5b0
Cr-Commit-Position: refs/heads/master@{#293724}

Powered by Google App Engine
This is Rietveld 408576698