Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3310)

Unified Diff: ash/system/web_notification/web_notification_tray_unittest.cc

Issue 551833002: Disable failing TouchFeedback tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/web_notification/web_notification_tray_unittest.cc
diff --git a/ash/system/web_notification/web_notification_tray_unittest.cc b/ash/system/web_notification/web_notification_tray_unittest.cc
index 2e89b661b2773d3fa4d8d7eb675f7cf9904a2069..4871753f590e62439032abc136eb5408924b1b18 100644
--- a/ash/system/web_notification/web_notification_tray_unittest.cc
+++ b/ash/system/web_notification/web_notification_tray_unittest.cc
@@ -478,12 +478,14 @@ TEST_F(WebNotificationTrayTest, MAYBE_PopupAndSystemTrayMultiDisplay) {
EXPECT_EQ(bottom_second, GetPopupWorkAreaBottomForTray(GetSecondaryTray()));
}
+// TODO(jonross): This test is failing on ASAN bots, fix the failure and
+// re-enable. (crbug.com/411881)
// TODO(jonross): Replace manually creating TouchEvent with
// EventGenerator.PressTouch/ReleaseTouch. Currently they set a width on the
// touch event causing the gesture recognizer to target a different view.
#if defined(OS_CHROMEOS)
// Tests that there is visual feedback for touch presses.
-TEST_F(WebNotificationTrayTest, TouchFeedback) {
+TEST_F(WebNotificationTrayTest, DISABLED_TouchFeedback) {
AddNotification("test_id");
RunAllPendingInMessageLoop();
WebNotificationTray* tray = GetTray();
@@ -512,9 +514,11 @@ TEST_F(WebNotificationTrayTest, TouchFeedback) {
EXPECT_FALSE(tray->IsMessageCenterBubbleVisible());
}
+// TODO(jonross): This test is failing on ASAN bots, fix the failure and
+// re-enable. (crbug.com/411881)
// Tests that while touch presses trigger visual feedback, that subsequent non
// tap gestures cancel the feedback without triggering the message center.
-TEST_F(WebNotificationTrayTest, TouchFeedbackCancellation) {
+TEST_F(WebNotificationTrayTest, DISABLED_TouchFeedbackCancellation) {
AddNotification("test_id");
RunAllPendingInMessageLoop();
WebNotificationTray* tray = GetTray();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698