Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 551823004: Reland r23732: ARM64: Fix and improve --trace-sim register trace. (Closed)

Created:
6 years, 3 months ago by jbramley
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland r23732: ARM64: Fix and improve --trace-sim register trace. - Use standard names (except that our GREY is the standard BLACK). - Make non-bold colours explicit, otherwise the boldness can carry over into subsequent colour declarations. - I've moved some colours around to make them consistent. Register value updates (which are very common) now stand out less than they did, making the less-common (and arguably more important) debug announcements appear brighter. - FP registers and values are now magenta. - Integer registers and values are now cyan. - Memory accesses are now blue. - LOG_WRITE prints the source register for stores. - Loads are logged with a format similar to that used for stores. Specifically, the memory address is printed alongside the new register value. - Updates to D registers print the raw bits as well as the double value. Updates to S registers print the raw bits as well as the float value. (Previously, we printed both double and float interpretations of the bits, which was a bit cluttered.) BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -232 lines) Patch
M src/arm64/disasm-arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/arm64/instructions-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/simulator-arm64.h View 9 chunks +113 lines, -42 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 30 chunks +361 lines, -187 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jbramley
This is r23732 (plus the fix in r23733) with a different workaround for the array-size ...
6 years, 3 months ago (2014-09-08 14:48:54 UTC) #2
Sven Panne
LGTM (rubberstamped), at least my local GCC is happy now.
6 years, 3 months ago (2014-09-09 08:16:57 UTC) #3
jbramley
6 years, 3 months ago (2014-09-09 12:43:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23802 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698