src/arm/lithium-arm.cc - Issue 551803005: The value register in storefield(smi) is not used as a temp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-arm.cc

Issue 551803005: The value register in storefield(smi) is not used as a temp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-arm.cc

diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc

index 7b97cb889e6619a4b3cf13cfcf1e4f828f96d8f4..9db5bd6678777d5e0e4cab41d44a76183876a201 100644

--- a/src/arm/lithium-arm.cc

+++ b/src/arm/lithium-arm.cc

@@ -2362,7 +2362,7 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {

}

LOperand* val;

- if (needs_write_barrier || instr->field_representation().IsSmi()) {

+ if (needs_write_barrier) {

val = UseTempRegister(instr->value());

} else if (instr->field_representation().IsDouble()) {

val = UseRegisterAtStart(instr->value());

« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »