Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 551803005: The value register in storefield(smi) is not used as a temp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-codegen-arm.h" 7 #include "src/arm/lithium-codegen-arm.h"
8 #include "src/hydrogen-osr.h" 8 #include "src/hydrogen-osr.h"
9 #include "src/lithium-inl.h" 9 #include "src/lithium-inl.h"
10 10
(...skipping 2344 matching lines...) Expand 10 before | Expand all | Expand 10 after
2355 obj = is_in_object 2355 obj = is_in_object
2356 ? UseRegister(instr->object()) 2356 ? UseRegister(instr->object())
2357 : UseTempRegister(instr->object()); 2357 : UseTempRegister(instr->object());
2358 } else { 2358 } else {
2359 obj = needs_write_barrier_for_map 2359 obj = needs_write_barrier_for_map
2360 ? UseRegister(instr->object()) 2360 ? UseRegister(instr->object())
2361 : UseRegisterAtStart(instr->object()); 2361 : UseRegisterAtStart(instr->object());
2362 } 2362 }
2363 2363
2364 LOperand* val; 2364 LOperand* val;
2365 if (needs_write_barrier || instr->field_representation().IsSmi()) { 2365 if (needs_write_barrier) {
2366 val = UseTempRegister(instr->value()); 2366 val = UseTempRegister(instr->value());
2367 } else if (instr->field_representation().IsDouble()) { 2367 } else if (instr->field_representation().IsDouble()) {
2368 val = UseRegisterAtStart(instr->value()); 2368 val = UseRegisterAtStart(instr->value());
2369 } else { 2369 } else {
2370 val = UseRegister(instr->value()); 2370 val = UseRegister(instr->value());
2371 } 2371 }
2372 2372
2373 // We need a temporary register for write barrier of the map field. 2373 // We need a temporary register for write barrier of the map field.
2374 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL; 2374 LOperand* temp = needs_write_barrier_for_map ? TempRegister() : NULL;
2375 2375
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
2639 LInstruction* LChunkBuilder::DoAllocateBlockContext( 2639 LInstruction* LChunkBuilder::DoAllocateBlockContext(
2640 HAllocateBlockContext* instr) { 2640 HAllocateBlockContext* instr) {
2641 LOperand* context = UseFixed(instr->context(), cp); 2641 LOperand* context = UseFixed(instr->context(), cp);
2642 LOperand* function = UseRegisterAtStart(instr->function()); 2642 LOperand* function = UseRegisterAtStart(instr->function());
2643 LAllocateBlockContext* result = 2643 LAllocateBlockContext* result =
2644 new(zone()) LAllocateBlockContext(context, function); 2644 new(zone()) LAllocateBlockContext(context, function);
2645 return MarkAsCall(DefineFixed(result, cp), instr); 2645 return MarkAsCall(DefineFixed(result, cp), instr);
2646 } 2646 }
2647 2647
2648 } } // namespace v8::internal 2648 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698