Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 551773002: Revert piece of "Removed Ctrl+Shift+P shortcut for system dialog printing on Windows." (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@r517193003
Project:
chromium
Visibility:
Public.

Description

Check still could be useful if code compiled without full printing. >> Removed Ctrl+Shift+P shortcut for system dialog printing on Windows. >> BUG=374321 >> Review URL: https://codereview.chromium.org/522493002 TBR=thestig@chromium.org NOTRY=true Committed: https://crrev.com/4d6758a4f12203ccb71283bd97abc6305b025f24 Cr-Commit-Position: refs/heads/master@{#293752}

Patch Set 1 : Mon Sep 8 02:06:35 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/browser_commands.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-08 09:11:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/551773002/20001
6 years, 3 months ago (2014-09-08 09:11:34 UTC) #3
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-08 09:11:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/551773002/20001
6 years, 3 months ago (2014-09-08 09:12:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/52785) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/13179) ios_dbg_simulator ...
6 years, 3 months ago (2014-09-08 09:16:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/551773002/20001
6 years, 3 months ago (2014-09-08 17:48:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 79718a32de1f1c6295ebcf13f4a4b8a7a32b0b49
6 years, 3 months ago (2014-09-08 17:54:16 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:06 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d6758a4f12203ccb71283bd97abc6305b025f24
Cr-Commit-Position: refs/heads/master@{#293752}

Powered by Google App Engine
This is Rietveld 408576698