Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 522493002: Removed Ctrl+Shift+P shortcut for system dialog printing on Windows. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tfarina, mazda+watch_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed Ctrl+Shift+P shortcut for system dialog printing on Windows. BUG=374321 Committed: https://crrev.com/29641fb308bf03c599f3ee1680c94985e84f8b01 Cr-Commit-Position: refs/heads/master@{#292681}

Patch Set 1 #

Patch Set 2 : Thu Aug 28 21:06:49 PDT 2014 #

Patch Set 3 : Thu Aug 28 21:07:58 PDT 2014 #

Total comments: 2

Patch Set 4 : Fri Aug 29 01:12:12 PDT 2014 #

Patch Set 5 : Fri Aug 29 11:27:33 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M chrome/app/chrome_dll.rc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 2 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (2 generated)
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-29 00:20:54 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-29 04:09:49 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/522493002/diff/40001/chrome/browser/ui/browser_command_controller.cc File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/522493002/diff/40001/chrome/browser/ui/browser_command_controller.cc#newcode1280 chrome/browser/ui/browser_command_controller.cc:1280: CanAdvancedPrint(browser_)); Also ifdef out CanAdvancedPrint() and AdvancedPrint() in ...
6 years, 3 months ago (2014-08-29 04:30:41 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:06:13 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:06:19 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/522493002/diff/40001/chrome/browser/ui/browser_command_controller.cc File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/522493002/diff/40001/chrome/browser/ui/browser_command_controller.cc#newcode1280 chrome/browser/ui/browser_command_controller.cc:1280: CanAdvancedPrint(browser_)); On 2014/08/29 04:30:41, Lei Zhang wrote: > Also ...
6 years, 3 months ago (2014-08-29 08:06:23 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:06:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/522493002/80001
6 years, 3 months ago (2014-08-29 08:06:37 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:06:44 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:08:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/522493002/100001
6 years, 3 months ago (2014-08-29 08:09:24 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:10:55 UTC) #12
Vitaly Buka (NO REVIEWS)
Patchset #6 (id:100001) has been deleted
6 years, 3 months ago (2014-08-29 08:12:45 UTC) #13
Vitaly Buka (NO REVIEWS)
Patchset #5 (id:80001) has been deleted
6 years, 3 months ago (2014-08-29 08:12:52 UTC) #14
Vitaly Buka (NO REVIEWS)
Patchset #4 (id:60001) has been deleted
6 years, 3 months ago (2014-08-29 08:13:03 UTC) #15
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 08:13:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/522493002/120001
6 years, 3 months ago (2014-08-29 08:13:32 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 09:08:27 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 09:41:27 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/9311)
6 years, 3 months ago (2014-08-29 09:41:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/522493002/120001
6 years, 3 months ago (2014-08-29 17:38:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/522493002/140001
6 years, 3 months ago (2014-08-29 18:30:12 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:140001) as 9a8647c9e76f653ea813caea40a451d2ecedca17
6 years, 3 months ago (2014-08-29 19:29:20 UTC) #25
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:29 UTC) #26
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/29641fb308bf03c599f3ee1680c94985e84f8b01
Cr-Commit-Position: refs/heads/master@{#292681}

Powered by Google App Engine
This is Rietveld 408576698