Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 551703002: Fix group datadeps (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix group datadeps NOTRY=true Committed: https://crrev.com/1b668a2e9177b3482ddfbc9bd3714e980b7cc5d1 Cr-Commit-Position: refs/heads/master@{#293952}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M tools/gn/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/ninja_group_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
A tools/gn/ninja_group_target_writer_unittest.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
cjhopman
brettw: *
6 years, 3 months ago (2014-09-08 01:03:47 UTC) #2
tfarina
Is there a test covering this?
6 years, 3 months ago (2014-09-08 01:56:35 UTC) #3
brettw
I am trying to write tests for the bugs that come up now, since the ...
6 years, 3 months ago (2014-09-08 20:05:48 UTC) #4
cjhopman
On 2014/09/08 20:05:48, brettw wrote: > I am trying to write tests for the bugs ...
6 years, 3 months ago (2014-09-08 23:27:07 UTC) #5
brettw
Please add the new file to the GYP build LGTM
6 years, 3 months ago (2014-09-08 23:29:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/551703002/60001
6 years, 3 months ago (2014-09-08 23:35:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9530)
6 years, 3 months ago (2014-09-09 06:25:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/551703002/60001
6 years, 3 months ago (2014-09-09 16:30:08 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 60acb3fc288f204009218788b1df6fcdf1a93821
6 years, 3 months ago (2014-09-09 16:52:26 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:49 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1b668a2e9177b3482ddfbc9bd3714e980b7cc5d1
Cr-Commit-Position: refs/heads/master@{#293952}

Powered by Google App Engine
This is Rietveld 408576698