Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: tools/gn/ninja_group_target_writer.cc

Issue 551703002: Fix group datadeps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/ninja_group_target_writer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/ninja_group_target_writer.h" 5 #include "tools/gn/ninja_group_target_writer.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "tools/gn/output_file.h" 8 #include "tools/gn/output_file.h"
9 #include "tools/gn/string_utils.h" 9 #include "tools/gn/string_utils.h"
10 #include "tools/gn/target.h" 10 #include "tools/gn/target.h"
(...skipping 10 matching lines...) Expand all
21 // A group rule just generates a stamp file with dependencies on each of 21 // A group rule just generates a stamp file with dependencies on each of
22 // the deps and datadeps in the group. 22 // the deps and datadeps in the group.
23 std::vector<OutputFile> output_files; 23 std::vector<OutputFile> output_files;
24 const LabelTargetVector& deps = target_->deps(); 24 const LabelTargetVector& deps = target_->deps();
25 for (size_t i = 0; i < deps.size(); i++) 25 for (size_t i = 0; i < deps.size(); i++)
26 output_files.push_back(deps[i].ptr->dependency_output_file()); 26 output_files.push_back(deps[i].ptr->dependency_output_file());
27 27
28 std::vector<OutputFile> data_output_files; 28 std::vector<OutputFile> data_output_files;
29 const LabelTargetVector& datadeps = target_->datadeps(); 29 const LabelTargetVector& datadeps = target_->datadeps();
30 for (size_t i = 0; i < datadeps.size(); i++) 30 for (size_t i = 0; i < datadeps.size(); i++)
31 data_output_files.push_back(deps[i].ptr->dependency_output_file()); 31 data_output_files.push_back(datadeps[i].ptr->dependency_output_file());
32 32
33 WriteStampForTarget(output_files, data_output_files); 33 WriteStampForTarget(output_files, data_output_files);
34 } 34 }
OLDNEW
« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/ninja_group_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698