Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 55153002: Adding test for old wrappers causing multiple upgrades (Closed)

Created:
7 years, 1 month ago by blois
Modified:
7 years, 1 month ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding test for old wrappers causing multiple upgrades This is the test for https://codereview.chromium.org/54833003/ BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=29704

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M tests/html/custom/template_wrappers_test.dart View 2 chunks +19 lines, -2 lines 2 comments Download
M tests/html/custom/template_wrappers_test.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
https://codereview.chromium.org/55153002/diff/30001/tests/html/custom/template_wrappers_test.dart File tests/html/custom/template_wrappers_test.dart (right): https://codereview.chromium.org/55153002/diff/30001/tests/html/custom/template_wrappers_test.dart#newcode77 tests/html/custom/template_wrappers_test.dart:77: var M = 100; Bumping down to 100 makes ...
7 years, 1 month ago (2013-10-31 18:43:13 UTC) #1
vsm
lgtm - siva is there a better pattern to force a gc from dart? this ...
7 years, 1 month ago (2013-10-31 19:30:43 UTC) #2
siva
https://codereview.chromium.org/55153002/diff/30001/tests/html/custom/template_wrappers_test.dart File tests/html/custom/template_wrappers_test.dart (right): https://codereview.chromium.org/55153002/diff/30001/tests/html/custom/template_wrappers_test.dart#newcode77 tests/html/custom/template_wrappers_test.dart:77: var M = 100; This seems like a very ...
7 years, 1 month ago (2013-10-31 19:49:05 UTC) #3
blois
I opened bug 14689 to investigate getting this working in Dartium- I don't think it's ...
7 years, 1 month ago (2013-10-31 20:20:53 UTC) #4
blois
7 years, 1 month ago (2013-10-31 21:16:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r29704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698