Adding test for old wrappers causing multiple upgrades

tests/html/custom/template_wrappers_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library template_wrappers_test;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:js' as js;
 import 'package:unittest/html_config.dart';
@@ skipping 14 matching lines @@
 // Pump custom events polyfill events.
 void customElementsTakeRecords() {
   if (js.context != null && js.context.hasProperty('CustomElements')) {
     js.context['CustomElements'].callMethod('takeRecords');
   }
 }
 
 main() {
   useHtmlConfiguration();
 
-  var registeredTypes = false;
   setUp(loadPolyfills);
 
   test('element is upgraded once', () {
 
     expect(createdCount, 0);
     document.register('x-custom', CustomElement);
     expect(createdCount, 1);
 
     forceGC();
 
     return new Future.delayed(new Duration(milliseconds: 50)).then((_) {
       var t = document.querySelector('.t1');
 
       var fragment = t.content;
 
       fragment.querySelector('x-custom').checkCreated();
       expect(createdCount, 1);
     });
   });
+
+  test('old wrappers do not cause multiple upgrades', () {
+    createdCount = 0;
+    var d1 = document.querySelector('x-custom-two');
+    d1.attributes['foo'] = 'bar';
+    d1 = null;
+
+    document.register('x-custom-two', CustomElement);
+
+    expect(createdCount, 1);
+
+    forceGC();
+
+    return new Future.delayed(new Duration(milliseconds: 50)).then((_) {
+      var d = document.querySelector('x-custom-two');
+      expect(createdCount, 1);
+    });
+  });
 }
 
 
 void forceGC() {
   var N = 1000000;
-  var M = 1000;
+  var M = 100;

[blois, 2013/10/31 18:43:13]

Bumping down to 100 makes this quite a bit faster and I'm still repro'ing the
behavior. Tests are currently flaky/timing out on bots.

Would be much better if we had a way to force GC.

[siva, 2013/10/31 19:49:05]

This seems like a very contrived way to trigger a GC.
The vm has an option --gc_at_alloc which forces a GC on every allocation. We
should see if there is a way to run this test with that additional option turned
on.

In standalone VM we have a mechanism which allows us to add an
option for a test, e.g:

// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

// VMOptions=--throw_on_javascript_int_overflow


import "package:expect/expect.dart";

int literals() {
  var okay_literal = 0x20000000000000;
  var too_big_literal = 0x20000000000001;  /// 01: compile-time error
  return okay_literal;
}

main() {
  Expect.equals(0x20000000000000, literals());
}

I don't know if this works when run inside dartium or not.



On 2013/10/31 18:43:13, blois wrote:

   for (var i = 0; i < M; ++i) {
     var l = new List(N);
   }
 }