Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 551523003: Revert of Use SkBitmapCache to optimize readPixels on a texture-backed bitmap (Closed)

Created:
6 years, 3 months ago by f(malita)
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Use SkBitmapCache to optimize readPixels on a texture-backed bitmap (patchset #6 id:100001 of https://codereview.chromium.org/533323002/) Reason for revert: Component inversions in Blink's printing/webgl-repeated-printing.html: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/24033/layout-test-results/printing/webgl-repeated-printing-diff.txt Reverting to unblock rolls. Original issue's description: > Use SkBitmapCache to optimize readPixels on a texture-backed bitmap > > BUG=skia:2786 > > Committed: https://skia.googlesource.com/skia/+/95fd68e5ccd242a91e6dd827dd695f18661efbe6 TBR=junov@chromium.org,reed@google.com,bsalomon@google.com,piotaixr@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2786 Committed: https://skia.googlesource.com/skia/+/90dc6412b46fa0bcf01ce45feeb4934fb774e7eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -49 lines) Patch
M src/gpu/SkGrPixelRef.cpp View 3 chunks +18 lines, -49 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Created Revert of Use SkBitmapCache to optimize readPixels on a texture-backed bitmap
6 years, 3 months ago (2014-09-09 15:11:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/551523003/1
6 years, 3 months ago (2014-09-09 15:12:43 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 15:12:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 90dc6412b46fa0bcf01ce45feeb4934fb774e7eb

Powered by Google App Engine
This is Rietveld 408576698