Issue 551353002: Use Object.preventExtensions instead of Object.seal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551353002: Use Object.preventExtensions instead of Object.seal. (Closed)

Created:
6 years, 3 months ago by iseki

Modified:
6 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Use Object.preventExtensions instead of Object.seal. * Object.seal use the more memory than Object.preventExtensions. BUG=402708 Committed: https://crrev.com/d79be4039cccd9fe0fa4f4798270df7f21ec57ef Cr-Commit-Position: refs/heads/master@{#293922}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/file_manager/file_manager/common/js/progress_center_common.js	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/551353002/1

6 years, 3 months ago (2014-09-09 10:50:56 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 382c88257ba714ec603a5fb103b5a62e6d67a14f

6 years, 3 months ago (2014-09-09 11:49:41 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:52:52 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d79be4039cccd9fe0fa4f4798270df7f21ec57ef
Cr-Commit-Position: refs/heads/master@{#293922}