ui/file_manager/file_manager/common/js/progress_center_common.js - Issue 551353002: Use Object.preventExtensions instead of Object.seal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/common/js/progress_center_common.js

Issue 551353002: Use Object.preventExtensions instead of Object.seal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/common/js/progress_center_common.js

diff --git a/ui/file_manager/file_manager/common/js/progress_center_common.js b/ui/file_manager/file_manager/common/js/progress_center_common.js

index 32311bf9c28c2f8a888fb875a4cde0623310003f..ec17aa100542a1f03822a1c04915ab8c28cd9a2a 100644

--- a/ui/file_manager/file_manager/common/js/progress_center_common.js

+++ b/ui/file_manager/file_manager/common/js/progress_center_common.js

@@ -115,7 +115,9 @@ var ProgressCenterItem = function() {

this.cancelCallback = null;

- Object.seal(this);

+ // This object is instantiated many time. Object.seal use more memory

+ // than Object.preventExtensions (crbug.com/412307)

+ Object.preventExtensions(this);

};

ProgressCenterItem.prototype = {

« no previous file with comments | « no previous file | no next file » | no next file with comments »