[Telemetry] Fix Chart JSON output typo bug and add unittest

[Telemetry] Fix Chart JSON output typo bug and add unittest

There was an issue with outputting Chart JSON that came down to a typo and was
not caught by unittests. This patch fixes the bug and adds a unittest to make
sure it won't crop up again.

R=nednguyen,sullivan

Committed: https://crrev.com/701934e5b0371bea45f09e9942fb5f4ac801ddc4
Cr-Commit-Position: refs/heads/master@{#294239}

[sullivan, 2014-09-10 17:09:22]

lgtm

[eakuefner, 2014-09-10 17:10:19]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2014-09-10 17:14:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eakuefner@chromium.org/551293003/1

[commit-bot: I haz the power, 2014-09-10 17:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 17:24:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eakuefner, 2014-09-10 17:24:27]

The CQ bit was unchecked by eakuefner@chromium.org

[sullivan, 2014-09-10 17:25:31]

This is still missing an OWNER review

[tonyg, 2014-09-10 17:29:39]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2014-09-10 17:29:39]

The CQ bit was checked by tonyg@chromium.org

[tonyg, 2014-09-10 17:29:40]

lgtm

[commit-bot: I haz the power, 2014-09-10 17:30:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eakuefner@chromium.org/551293003/1

[nednguyen, 2014-09-10 17:42:24]

https://codereview.chromium.org/551293003/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py
(right):

https://codereview.chromium.org/551293003/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py:43:
json.loads(self._output.getvalue())
For even more sanity, maybe asserting the foo value is presented in this dict?

[eakuefner-google (do not use), 2014-09-10 17:44:46]

The CQ bit was unchecked by eakuefner@google.com

[eakuefner, 2014-09-10 17:46:58]

https://codereview.chromium.org/551293003/diff/1/tools/telemetry/telemetry/re...
File tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py
(right):

https://codereview.chromium.org/551293003/diff/1/tools/telemetry/telemetry/re...
tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py:43:
json.loads(self._output.getvalue())
On 2014/09/10 17:42:24, nednguyen wrote:
> For even more sanity, maybe asserting the foo value is presented in this dict?

Done.

[nednguyen, 2014-09-10 17:52:17]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-09-10 17:52:17]

lgtm

[commit-bot: I haz the power, 2014-09-10 17:54:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eakuefner@chromium.org/551293003/20001

[commit-bot: I haz the power, 2014-09-10 20:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 20:33:02]

Exceeded time limit waiting for builds to trigger.

[eakuefner, 2014-09-10 20:39:08]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:01:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eakuefner@chromium.org/551293003/20001

[commit-bot: I haz the power, 2014-09-10 22:11:57]

Committed patchset #2 (id:20001) as 37b18fc6f8172ac075792e9d558cfcf660e7fdba

[commit-bot: I haz the power, 2014-09-10 22:13:58]

Patchset 2 (id:??) landed as
https://crrev.com/701934e5b0371bea45f09e9942fb5f4ac801ddc4
Cr-Commit-Position: refs/heads/master@{#294239}