tools/telemetry/telemetry/results/chart_json_output_formatter.py - Issue 551293003: [Telemetry] Fix Chart JSON output typo bug and add unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/chart_json_output_formatter.py

Issue 551293003: [Telemetry] Fix Chart JSON output typo bug and add unittest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ned's comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/results/chart_json_output_formatter.py

diff --git a/tools/telemetry/telemetry/results/chart_json_output_formatter.py b/tools/telemetry/telemetry/results/chart_json_output_formatter.py

index 3b262c8df288161298c8e7d55ac1dedfb0e9aa4f..065bbc24e63c705d93db037dcc310de070661b7e 100644

--- a/tools/telemetry/telemetry/results/chart_json_output_formatter.py

+++ b/tools/telemetry/telemetry/results/chart_json_output_formatter.py

@@ -65,7 +65,7 @@ class ChartJsonOutputFormatter(output_formatter.OutputFormatter):

self._benchmark_metadata = benchmark_metadata

def Format(self, page_test_results):

- json.dump(self._ResultsAsChartDict(

+ json.dump(_ResultsAsChartDict(

self._benchmark_metadata,

page_test_results.all_page_specific_values,

page_test_results.all_summary_values),

« no previous file with comments | « no previous file | tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py » ('j') | no next file with comments »