Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 551283002: Remove HTMLInputElement::isText and isTextType. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, dmazzoni, aboxhall
Project:
blink
Visibility:
Public.

Description

Remove HTMLInputElement::isText and isTextType. They are same and very confusing. isText is used outside of HTMLInputElement. It can be replaced with |isTextField() && type() != InputTypeNames::number|. isTextType is used only in HTMLInputElement. Its callsites should be replaced with virtual function dispatches. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181614

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -48 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 3 chunks +1 line, -24 lines 0 comments Download
M Source/core/html/forms/BaseTextInputType.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +16 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.h View 3 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 3 chunks +10 lines, -5 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-09 06:11:01 UTC) #3
keishi
lgtm
6 years, 3 months ago (2014-09-09 07:39:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/551283002/20001
6 years, 3 months ago (2014-09-09 07:42:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 07:45:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 181614

Powered by Google App Engine
This is Rietveld 408576698