Source/core/html/forms/TextFieldInputType.cpp - Issue 551283002: Remove HTMLInputElement::isText and isTextType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 551283002: Remove HTMLInputElement::isText and isTextType. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 1794ee257b71fb8ed582fb0e81a60406cb94ab21..67866290bfacd113fe0f8324473eed59a8d82005 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -419,7 +419,7 @@ void TextFieldInputType::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*

// Selected characters will be removed by the next text event.

unsigned baseLength = oldLength - selectionLength;

- unsigned maxLength = static_cast<unsigned>(isTextType() ? element().maxLength() : HTMLInputElement::maximumLength); // maxLength can never be negative.

+ unsigned maxLength = static_cast<unsigned>(this->maxLength()); // maxLength can never be negative.

unsigned appendableLength = maxLength > baseLength ? maxLength - baseLength : 0;

// Truncate the inserted text to avoid violating the maxLength and other constraints.

« no previous file with comments | « Source/core/html/forms/InputType.cpp ('k') | Source/web/WebInputElement.cpp » ('j') | no next file with comments »