Source/core/rendering/RenderMultiColumnSpannerSet.h - Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerSet.h

Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress. (Closed) Base URL: git:blink.git@new-multicol-no-renderer-reparenting

Patch Set: Copy margin properties from a spanner to its spanner set, to simplify code. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/RenderMultiColumnFlowThread.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSpannerSet.h

diff --git a/Source/core/rendering/RenderMultiColumnSpannerSet.h b/Source/core/rendering/RenderMultiColumnSpannerSet.h

index b851147bb87ddefab7266d358ecc94c907bf222a..2a8f721e70402025afe23cf99f79597fb050a13e 100644

--- a/Source/core/rendering/RenderMultiColumnSpannerSet.h

+++ b/Source/core/rendering/RenderMultiColumnSpannerSet.h

@@ -16,6 +16,8 @@ public:

static RenderMultiColumnSpannerSet* createAnonymous(RenderMultiColumnFlowThread*, RenderStyle* parentStyle, RenderBox*);

RenderBox* renderer() const { return m_renderer; }

+ void updateMarginProperties(RenderStyle* newStyle, const RenderObject* spannerBlock) const;

virtual bool recalculateColumnHeight(BalancedHeightCalculation) OVERRIDE;

protected:

« no previous file with comments | « Source/core/rendering/RenderMultiColumnFlowThread.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerSet.cpp » ('j') | no next file with comments »