Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: Source/core/rendering/RenderMultiColumnSpannerSet.h

Issue 551263005: *** DO NOT LAND *** Implement column-span:all without reparenting renderers. Work in progress. (Closed) Base URL: git:blink.git@new-multicol-no-renderer-reparenting
Patch Set: Copy margin properties from a spanner to its spanner set, to simplify code. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef RenderMultiColumnSpannerSet_h 5 #ifndef RenderMultiColumnSpannerSet_h
6 #define RenderMultiColumnSpannerSet_h 6 #define RenderMultiColumnSpannerSet_h
7 7
8 #include "core/rendering/RenderMultiColumnSet.h" 8 #include "core/rendering/RenderMultiColumnSet.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class RenderMultiColumnSpannerSet FINAL : public RenderMultiColumnSet { 12 class RenderMultiColumnSpannerSet FINAL : public RenderMultiColumnSet {
13 public: 13 public:
14 virtual bool isRenderMultiColumnSpannerSet() const OVERRIDE { return true; } 14 virtual bool isRenderMultiColumnSpannerSet() const OVERRIDE { return true; }
15 15
16 static RenderMultiColumnSpannerSet* createAnonymous(RenderMultiColumnFlowThr ead*, RenderStyle* parentStyle, RenderBox*); 16 static RenderMultiColumnSpannerSet* createAnonymous(RenderMultiColumnFlowThr ead*, RenderStyle* parentStyle, RenderBox*);
17 17
18 RenderBox* renderer() const { return m_renderer; } 18 RenderBox* renderer() const { return m_renderer; }
19 void updateMarginProperties(RenderStyle* newStyle, const RenderObject* spann erBlock) const;
20
19 virtual bool recalculateColumnHeight(BalancedHeightCalculation) OVERRIDE; 21 virtual bool recalculateColumnHeight(BalancedHeightCalculation) OVERRIDE;
20 22
21 protected: 23 protected:
22 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const OVERRIDE; 24 virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logic alTop, LogicalExtentComputedValues&) const OVERRIDE;
23 virtual LayoutUnit pageLogicalHeight() const OVERRIDE; 25 virtual LayoutUnit pageLogicalHeight() const OVERRIDE;
24 virtual const char* renderName() const OVERRIDE; 26 virtual const char* renderName() const OVERRIDE;
25 27
26 private: 28 private:
27 RenderMultiColumnSpannerSet(RenderMultiColumnFlowThread*, RenderBox*); 29 RenderMultiColumnSpannerSet(RenderMultiColumnFlowThread*, RenderBox*);
28 30
29 RenderBox* m_renderer; // The column span renderer. 31 RenderBox* m_renderer; // The column span renderer.
30 }; 32 };
31 33
32 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSpannerSet, isRenderMultiColumn SpannerSet()); 34 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSpannerSet, isRenderMultiColumn SpannerSet());
33 35
34 } // namespace blink 36 } // namespace blink
35 37
36 #endif 38 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderMultiColumnFlowThread.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698